lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [PATCH] fix InputSequenceEditor error messages


From: Greg Chicares
Subject: Re: [lmi] [PATCH] fix InputSequenceEditor error messages
Date: Sun, 07 Aug 2011 17:09:05 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10

On 2011-07-12 14:31Z, Vaclav Slavik wrote:
> 
> please apply this simple patch on top of the others.
> It fixes diagnostics messages to use human numbering instead
> of zero-based.

Actually, lmi uses zero-based ordinals elsewhere, eg, on the "Reports" tab:
  Column 0
  Column 1
  ...
(and implicitly, I would say, within the input-sequence grammar), so my
preference would be to maintain consistent usage (and therefore not apply
this patch). But if wx has a function to transform an int to an ordinal
string that cannot be confused with a cardinal number, eg:
  "Invalid keyword \"%s\" on %s row.", value.c_str(), OrdinalOf(row + 1));
  row=0 --> "1st"
  row=1 --> "2nd"
  ...
then I wouldn't object to using that. (The high-scoring answer here:
  
http://stackoverflow.com/questions/69262/is-there-an-easy-way-in-net-to-get-st-nd-rd-and-th-endings-for-numbers
appears to be correct for English.)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]