Re: [lmi] [PATCH 1/2] Make InputSequenceEntry friendly to embedding in wxDVC.

[Vadim Zeitlin]

On Mon, 8 Aug 2011 19:33:09 +0200 Václav Slavík <address@hidden> wrote:

VS> On 7 Aug 2011, at 23:05, Greg Chicares wrote:
VS> >  On "Payments" tab, paste this into "Individual payment":
VS> >    40000 2;99999;100000;100001;110000;120000;130000;140000;150000;0
VS> >  Click "..." [the "40000" field is highlighted]
VS> >  Press Enter [the "40000" is overwritten
VS> 
VS> I don't see that when I press Enter, it behaves as I would expect: the
VS> dialog is closed immediately with no change to the data (with wx
VS> trunk).
VS> 
VS> What I do see, however, is that the Individual payment text entry in
VS> the background is updated as you type and so the problem is visible
VS> even here: neither OK nor Cancel have any effect, as the data are
VS> updated immediately.

 Things are getting more interesting: I don't see this behaviour with wx
trunk (r68606) and neither "tt" nor "sequence-editor" branches of our git
repository (BTW, Vaclav, would be great if you could merge tt into the
latter unless you plan to delete it soon because I have to apply cee04c0
commit from tt manually every time I need to test it). I've only tested the
MSW build so far and will test g++ one soon but I just don't see how could
this be compiler-dependent so I must be missing something here. All I did
was to follow Greg's original instructions (in 07 Aug 2011 21:05:09 +0000
message) to the letter and I don't see neither the error about 40000 being
invalid, nor any changes to the string in the main illustration properties
dialog. Vaclav, am I testing the wrong code by chance?

VS> But I am truly baffled by this: TransferDataFromWindow() is apparently
VS> called after every change, but this isn't making any sense.

 If it helps, it doesn't make any sense to me neither and I don't see how
could it. TransferDataFromWindow() is only called from
wxDialgBase::OnButton() (either directly or from AcceptAndClose()) and this
is only supposed to be called when Ok or Cancel button (or assimilated) is
pressed. Do you see where is it called from in this case?

 Thanks,
VZ