Re: [lmi] [PATCH 1/2] Make InputSequenceEntry friendly to embedding in wxDVC.

[Vadim Zeitlin]

On Tue, 09 Aug 2011 11:40:51 +0000 Greg Chicares <address@hidden> wrote:

GC> > VS> I already mentioned one quick fix.
GC> 
GC> "The fix is simple, just don't apply this patch." That's best for now.
GC> I have little enough time available to finish other work I must do for
GC> the month-end release.

 Yes, sorry for not realizing that the problem only arose with this patch.

GC> >  I agree that neither of TransferDataFromWindow(), TransferDataToWindow()
GC> > nor Validate() should "descend" into their top level children.
GC> 
GC> Yes, I was very surprised that this descent occurred.

 We'll change this in wxWidgets but I'd like to discuss this on wx-dev
first. I don't think anybody is going to object to changing the current
behaviour which is really surprising (but was never noticed because
TransferDataFromWindow() is only called when the dialog is being closed
usually and by then it can't have any modal dialogs, of course), but I'd
like to discuss the possibility of a more in depth fix to this issue than
just adding IsTopLevel() checks to all these functions.

GC> > This is trivial to change in wx (we basically just need to test for
GC> > child->IsTopLevel() inside all these functions) but it won't help if
GC> > you plan to use 2.9.2 for the August release and something like above
GC> > would still be required.
GC> 
GC> Let's defer the patch in Vaclav's 2011-07-13T16:55Z email until that
GC> change is made in 2.9.3 .

 Yes, knowing that the problem is only with this patch, this is definitely
the right thing to do. And I'll follow up here when the issue is resolved
in wx itself.

 Regards,
VZ