Re: [lmi] [PATCH 3/3] Fix incorrect use of unqualified GetLabel().

[Greg Chicares]

On 2014-09-29 14:30Z, Vadim Zeitlin wrote:
[...]
>  multidimgrid_tools.hpp | 2 +-
[...]
> @@ -360,7 +360,7 @@ void AdjustableMaxBoundAxis<Integral>::UpdateChoiceControl
>  
>      while(choice.GetCount() < new_count)
>          {
> -        choice.Append(GetLabel(choice.GetCount() + min_value));
> +        choice.Append(this->GetLabel(choice.GetCount() + min_value));
>          }

Okay, I see the problem, although I don't understand the solution.
'this' is of type AdjustableMaxBoundAxis<Integral>, which is
derived from MultiDimAdjustableAxis, which is derived from...well,
I guess ultimately this must lead to a wx class that implements
GetLabel, though I didn't take the time to follow every link in a
chain whose end I can't immediately see. Would it be okay if I
instead used applied the following change?

-        choice.Append(GetLabel(choice.GetCount() + min_value));
+        choice.Append(choice.GetLabel(choice.GetCount() + min_value));

I figure that 'choice.Append()' and 'choice.GetCount()' are
already known to work, so 'choice.GetLabel()' should work as well.