[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] [PATCH 3/3] Fix incorrect use of unqualified GetLabel().
|
From: |
Greg Chicares |
|
Subject: |
Re: [lmi] [PATCH 3/3] Fix incorrect use of unqualified GetLabel(). |
|
Date: |
Thu, 02 Oct 2014 17:22:56 +0000 |
|
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 2014-10-02 14:48Z, Vadim Zeitlin wrote:
> On Thu, 02 Oct 2014 14:34:32 +0000 Greg Chicares <address@hidden> wrote:
[...GetLabel() not found by ADL; my cursory analysis let me to speculate...]
> GC> I guess ultimately this must lead to a wx class that implements
> GC> GetLabel,
>
> No, the class hierarchy is
>
> AdjustableMaxBoundAxis<Integral>
> MultiDimAdjustableAxis<T,MultiDimIntegralAxis<Integral>> // CRTP
> MultiDimIntegralAxis<Integral>
> MultiDimAxis<Integral>
> MultiDimAxisAny
>
> and GetLabel() is a pure virtual method of MultiDimAxisAny (which doesn't
> derive from any wx-related class) and its implementation is provided by
> MultiDimIntegralAxis<Integral>.
Oh. Well, thanks for analyzing it correctly.
[...snip my alternative patch, which...]
> doesn't look obvious, so I'd rather apply my proposed change and avoid
> changing the code behaviour if it runs correctly now.
Good, that's what I'll do.