Re: [lmi] Defect in wx trunk?

[Greg Chicares]

On 2014-10-19 19:07Z, Vadim Zeitlin wrote:
> On Sun, 19 Oct 2014 18:27:26 +0000 Greg Chicares <address@hidden> wrote:
[...]
> GC> ../src/msw/evtloopconsole.cpp: In member function `int 
> wxMSWEventLoopBase::GetNextMessageTimeout(WXMSG*, long unsigned int)':
> GC> ../src/msw/evtloopconsole.cpp:130: error: `wxZeroMemory' was not declared 
> in this scope
> GC> ../src/msw/evtloopconsole.cpp:130: warning: unused variable 'wxZeroMemory'
> GC> Makefile:17592: recipe for target 'monodll_evtloopconsole.o' failed
> GC> make[2]: *** [monodll_evtloopconsole.o] Error 1
[...]
>  I've applied a blind fix for this in r78049 (should be propagated to git
> mirror in ~5 minutes) and will try to actually retest LMI build with the
> latest wx later tonight and check if anything is still broken.

Okay, with that fix, everything builds now. Latest 'wx_test' results:

12:39:15: Starting automatic tests:
12:39:15:     about_dialog_version: ok (68ms)
12:39:15: Error: can't open file 'wx_test.conf' (error 2: the system cannot 
find the file specified.)
12:39:15:     benchmark_census: ERROR (Assertion failure: can't read from 
closed file [file ../src/common/ffile.cpp, line 128, in Read()].)
12:39:22:     calculation_summary: ok (6754ms)
12:39:22:     configurable_settings: ERROR (Assertion 
'fs::exists("/etc/opt/lmi/configurable_settings.xml")' failed. [file 
/lmi/src/lmi/wx_test_config_settings.cpp, line 37] )
12:39:22:     create_open_census: ok (152ms)
12:39:23:     create_open_database: ok (1145ms)
12:39:24:     create_open_gpt: ok (434ms)
12:39:25:     create_open_illustration: ok (1195ms)
12:39:25:     create_open_mec: ok (287ms)
12:39:26:     create_open_policy: ok (202ms)
12:39:26:     create_open_rounding: ok (353ms)
12:39:26:     create_open_strata: ok (559ms)
12:39:27:     create_open_text: ok (56ms)
12:39:27:     default_input: ERROR (Assertion '(effective_date) == 
(first_of_month)' failed (expected 2456932 vs observed 2456951). [file 
/lmi/src/lmi/wx_test_default_input.cpp, line 44] )
12:39:27:     default_update: ERROR (Assertion failure: A message box "Unable 
to read file 'C:/etc/opt/lmi/default.ill'. [file 
/lmi/src/lmi/illustration_document.cpp, line 110] " was shown unexpectedly, 
expected wxDialog. [file /opt/lmi/local/include/wx-3.1/wx/testing.h, line 315, 
in ReportFailure()].)
12:39:27:     expiry_dates: ERROR (Assertion '(end) == (end_of_month)' failed 
(expected 2450480 vs observed 2458849). [file 
/lmi/src/lmi/wx_test_expiry_dates.cpp, line 77] )
12:39:27:     extract: ERROR (Assertion failure: Expected wxMessageDialog 
dialog was not shown. [file /opt/lmi/local/include/wx-3.1/wx/testing.h, line 
315, in ReportFailure()].)
12:39:27:     input_sequences: ERROR (Assertion failure: A message box "Sorry, 
could not open this file." was shown unexpectedly. [file 
/opt/lmi/local/include/wx-3.1/wx/testing.h, line 315, in ReportFailure()].)
12:39:27:     input_validation: ERROR (Assertion failure: A message box "Sorry, 
could not open this file." was shown unexpectedly. [file 
/opt/lmi/local/include/wx-3.1/wx/testing.h, line 315, in ReportFailure()].)
12:39:28:     paste_census: ok (1186ms)
12:39:36:     pdf_census: ok (8383ms)
12:39:39:     pdf_illustration: ok (2496ms)
12:39:40:     validate_output_illustration: ERROR (Assertion failure: Expected 
wxDialog dialog was not shown. [file 
/opt/lmi/local/include/wx-3.1/wx/testing.h, line 315, in ReportFailure()].)
12:39:40:     validate_output_mec: ERROR (Assertion failure: A message box 
"Sorry, could not open this file." was shown unexpectedly, expected wxDialog. 
[file /opt/lmi/local/include/wx-3.1/wx/testing.h, line 315, in 
ReportFailure()].)
12:39:40: FAILURE: 10 out of 24 tests failed.

That's equivalent to the results I reported 2014-10-19T00:02Z, except that
this warning
  ../src/msw/mimetype.cpp at line 272: 'AssocQueryString' failed
no longer appears--as expected, because the newer version of wx fixes that.

The problem reported 2014-10-19T00:46Z still persists. As I mentioned in
that email, I had already applied the patch in your 2014-10-19T00:16Z email.
This seemed intriguing, so I looked into it myself. That patch certainly
seems to do what it intends to; if that's not the problem, then what is?
Experimentally, I tried the password documented "pedo mellon a minno", and
most of the problems went away. Aha: 'wx_test' tests some features that are
available only with a password--either "say 'Friend' and enter" in Sindarin,
or the other one that we dare not speak aloud. And that's probably why the
floating menu appears: certain file extensions are recognized conditionally,
as determined by Skeleton::InitDocManager().

I think it would be fragile to copy those conditionals to 'wx_test', but
could the tests that open a file other than '.cns' or '.ill' be conditioned
on whether a corresponding wxDocTemplate is available at run time? Thus, for
example, instead of this error
  create_open_text: ERROR (Assertion failure: Expected wxFileDialog dialog was 
not shown.
that appears without the most powerful password, could we either just skip
the test silently, or substitute a message like
  create_open_text: Skipped (no corresponding wxDocTemplate)
? I'm personally indifferent which of those two options is chosen.

I think it's important to be able to test with any password, or with none,
so that we can run 'wx_test' the same way end users run 'lmi_wx_shared'.
Sometimes I add speculative code conditioned with a password or other
command-line argument that no end user would ever use, and we should be
able to test the non-speculative alternative.