Re: [lmi] Pedantic error in wxPdfDoc (was: Compiling takes longer with gcc-4.9.2)

[Vadim Zeitlin]

On Tue, 22 Dec 2015 01:06:27 +0000 Greg Chicares <address@hidden> wrote:

GC> Here's the "pedantic" error:
GC> 
GC> /usr/bin/i686-w64-mingw32-g++  -MMD -MP -MT group_quote_pdf_gen_wx.o -MF 
group_quote_pdf_gen_wx.d\
GC>  -c -I /lmi/src/lmi -I /lmi/src/lmi/tools/pete-2.1.1 -I 
/opt/lmi/local/lib/wx/include/i686-pc-mingw32-msw-unicode-3.1\
GC>  -I /opt/lmi/local/include/wx-3.1 -I /opt/lmi/third_party/include -I 
/opt/lmi/third_party/src -I /opt/lmi/local/include\
GC>  -I /opt/lmi/local/include/libxml2 -DLMI_WX_NEW_USE_SO  -DLIBXML_USE_DLL 
-DSTRICT    -D_FILE_OFFSET_BITS=64\
GC>  -DWXUSINGDLL -D__WXMSW__ -DBOOST_STRICT_CONFIG   -std=c++03 
-pedantic-errors -Werror -Wall -Wcast-align -Wconversion\
GC>  -Wdeprecated-declarations -Wdisabled-optimization -Wimport -Wmultichar 
-Wpacked -Wpointer-arith -Wsign-compare -Wundef\
GC>  -Wwrite-strings  -Wno-long-long -Wctor-dtor-privacy -Wdeprecated 
-Wnon-template-friend -Woverloaded-virtual\
GC>  -Wpmf-conversions -Wsynth   -Wno-unused-local-typedefs -Wno-conversion 
-Wno-unused-variable -Wno-deprecated-declarations \
GC>  -Wno-parentheses -Wno-variadic-macros      -ggdb -O2    
/lmi/src/lmi/group_quote_pdf_gen_wx.cpp -ogroup_quote_pdf_gen_wx.o
GC> 
GC> In file included from /opt/lmi/local/include/wx/pdfdocument.h:25:0,
GC>                  from /opt/lmi/local/include/wx/pdfdc.h:21,
GC>                  from /lmi/src/lmi/group_quote_pdf_gen_wx.cpp:56:
GC> /opt/lmi/local/include/wx/pdfarraytypes.h:27:86: error: invoking macro 
WX_DEFINE_SORTED_USER_EXPORTED_TYPEARRAY argument 4: \
GC> empty macro arguments are undefined in ISO C90 and ISO C++98
GC>  WX_DEFINE_SORTED_USER_EXPORTED_ARRAY_INT(int, wxPdfSortedArrayInt, 
WXDLLIMPEXP_PDFDOC);
GC>                                                                             
          ^
GC> /lmi/src/lmi/workhorse.make:798: recipe for target 
'group_quote_pdf_gen_wx.o' failed
GC> 
GC> Is it not possible to patch that problem, e.g. by passing '/**/' as the
GC> missing macro argument?

 It should be by using wxEMPTY_PARAMETER_VALUE which exists just for this
purpose, i.e. writing

WX_DEFINE_SORTED_USER_EXPORTED_ARRAY_INT(int, wxPdfSortedArrayInt, 
wxEMPTY_PARAMETER_VALUE WXDLLIMPEXP_PDFDOC);

 But I'm surprised by something else: WXDLLIMPEXP_PDFDOC is not supposed to
be empty in the first place, with WXUSINGDLL defined (as it is in the
command line above), wxPdfDoc considers that it is a DLL too by default
(this can be overridden by defining WXUSINGLIB_PDFDOC, but this symbol is
not defined) and should define WXDLLIMPEXP_PDFDOC as a non-empty WXIMPORT
macro in its wx/pdfdocdef.h. Can you see why doesn't this happen by chance?
If not, please just patch wxPdfDoc in any dirty way for now and I'll try to
really understand what's going on here later.

 Good luck,
VZ