Re: [lmi] MDI child frame and wxEVT_MENU_HIGHLIGHT

[Vadim Zeitlin]

On Wed, 30 Mar 2016 13:09:33 +0000 Greg Chicares <address@hidden> wrote:

GC> 
https://github.com/vadz/lmi/pull/8/commits/60ddc3976b8b0c1a3a966e032d10e144d46c9ebb
GC> | Remove the attempts to use MDI parent status bar for menu help display.
GC> |
GC> | This code actually had no effect because the MDI child frame never 
received
GC> | wxEVT_MENU_HIGHLIGHT anyhow and the help was (correctly) displayed in the
GC> | parent frame status bar just because this is where all the events went.
GC> 
GC> Just to be sure, let me ask whether you carefully read lines 29-58 here:
GC>   
http://svn.savannah.nongnu.org/viewvc/lmi/trunk/docmdichildframe_ex.hpp?annotate=6443&root=lmi
GC> I'm quite sure that this code did have an effect eleven years ago when it 
was
GC> written, and that comment block explains why. If you're saying that was 
never
GC> true even in 2005, then I'd be surprised.

 To be honest, I don't remember whether I had noticed this comment and I
guess it's possible that things worked differently in 2005 (if you remember
which wxWidgets version lmi used back then, I could test it, but svn
history only starts from the end of 2007, so I don't even know what to
test). But I am quite sure that this code is not needed now and that things
work correctly without it which, I think, is what really counts.

 Regards,
VZ