Re: [lmi] [lmi-commits] Explain why GUI shows skin filenames with extension

[Vadim Zeitlin]

On Tue, 31 May 2016 21:06:23 +0000 (UTC) Greg Chicares <address@hidden> wrote:

GC> branch: master
GC> commit c84b3b897ad7a02d06e5d99841ad8e21068eb52e
GC> Author: Gregory W. Chicares <address@hidden>
GC> Date:   Tue May 31 20:46:11 2016 +0000
GC> 
GC>     Explain why GUI shows skin filenames with extension
GC> ---
GC>  ce_skin_name.hpp |   16 ++++++++++------
GC>  1 file changed, 10 insertions(+), 6 deletions(-)
GC> 
GC> diff --git a/ce_skin_name.hpp b/ce_skin_name.hpp
GC> index 8053c96..425be20 100644
GC> --- a/ce_skin_name.hpp
GC> +++ b/ce_skin_name.hpp
GC> @@ -30,14 +30,18 @@
GC>  #include <string>
GC>  #include <vector>
GC>  
GC> -/// This class encapsulates skin names. As for the related class
GC> -/// ce_product_name, its values are only available at run time, so
GC> +/// This class encapsulates skin names. As with the related class
GC> +/// ce_product_name, its values are available only at run time, so
GC>  /// there can be no compile time enum to represent them.
GC>  ///
GC> -/// Valid values are the base names of 'skin*.xrc' product files found
GC> -/// in the (configurable) data directory. As with ce_product_name, the
GC> -/// valid values never change during the program lifetime and it needs
GC> -/// to be restarted to "notice" any new skins.
GC> +/// Valid values are the full (base + extension) names of 'skin*.xrc'
GC> +/// skin files found in the (configurable) data directory. As with
GC> +/// ce_product_name, the valid values never change during the program
GC> +/// lifetime and it needs to be restarted to "notice" any new skins.
GC> +/// Unlike ce_product_name, the full file names are presented in the
GC> +/// GUI: base names of '.policy' files are designed to be recognizable
GC> +/// to end users, but '.skin' names are more esoteric and it is less
GC> +/// confusing to show them as file names rather than apparent phrases.

 Sorry, but '.skin' here looks wrong: IMHO it should be either '.xrc' or
'skin*'.

 Please let me know if/when I should stop with nitpicking,
VZ