Re: [lmi] [lmi-commits] Explain why GUI shows skin filenames with extension

[Greg Chicares]

On 2016-05-31 21:24, Vadim Zeitlin wrote:
> On Tue, 31 May 2016 21:06:23 +0000 (UTC) Greg Chicares <address@hidden> wrote:
> 
> GC> branch: master
> GC> commit c84b3b897ad7a02d06e5d99841ad8e21068eb52e
> GC> Author: Gregory W. Chicares <address@hidden>
> GC> Date:   Tue May 31 20:46:11 2016 +0000
[...]
> GC> +/// Unlike ce_product_name, the full file names are presented in the
> GC> +/// GUI: base names of '.policy' files are designed to be recognizable
> GC> +/// to end users, but '.skin' names are more esoteric and it is less
> GC> +/// confusing to show them as file names rather than apparent phrases.
> 
>  Sorry, but '.skin' here looks wrong: IMHO it should be either '.xrc' or
> 'skin*'.

Thanks, fixed:

commit 6d564d64f9d55288561fe59483b29947cb1783bf

Author: Gregory W. Chicares <address@hidden>

Date:   Tue May 31 23:13:32 2016 +0000



    Fix defect introduced 20160531T2046: confusing comment



diff --git a/ce_skin_name.hpp b/ce_skin_name.hpp

index 425be20..59ef375 100644

--- a/ce_skin_name.hpp

+++ b/ce_skin_name.hpp

@@ -40,7 +40,7 @@

 /// lifetime and it needs to be restarted to "notice" any new skins.

 /// Unlike ce_product_name, the full file names are presented in the

 /// GUI: base names of '.policy' files are designed to be recognizable

-/// to end users, but '.skin' names are more esoteric and it is less

+/// to end users, but skin names are more esoteric and it is less

 /// confusing to show them as file names rather than apparent phrases.


>  Please let me know if/when I should stop with nitpicking,

| Il semble que la perfection soit atteinte non quand il n'y a plus
| rien à ajouter, mais quand il n'y a plus rien à retrancher.