lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Pagination anomaly


From: Greg Chicares
Subject: Re: [lmi] Pagination anomaly
Date: Tue, 6 Feb 2018 00:27:03 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 2018-02-05 22:00, Vadim Zeitlin wrote:
[...]
>  While still thinking about a better way to do it, I've at least written
> and run the following program:
[...]
> TEST_CASE()

What testing framework does that use?

I often write throwaway tests like that by editing 'sandbox_test.cpp',
though it doesn't matter how it's done if it's going to be thrown away.
But maybe this will suggest an abstraction that can be factored out and
tested independently. (Or maybe not--there's a limit to how far we
should contort the code to make it unit-testable.)

> and swiftly found another off-by-one problem which requires this fix:
[...]
> which I've added as the third commit to https://github.com/vadz/lmi/pull/63

I've merged and pushed that.

I always inspect changes before pushing, and was surprised to see that
there were four commits queued up when I had seen only three via
github's html interface...but of course you added a fourth to pull/63
in the meanwhile. That's perfectly okay--it just seemed spooky.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]