lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Navigate by color in `git-diff --color-moved=plain`


From: Greg Chicares
Subject: Re: [lmi] Navigate by color in `git-diff --color-moved=plain`
Date: Thu, 25 Apr 2019 12:39:06 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 2019-04-25 09:46, Greg Chicares wrote:
> On 2019-04-24 23:00, Vadim Zeitlin wrote:
[...]
>> 1. Is this reproducible?
>> 2. If yes, does it still happen with bash instead of dash?
[...]
> resume this thread later
> if any similar anomaly is seen in future.

It happened again:

-+ find /cache_for_lmi/downloads -type+  f
-xargs md5sum

with a misplaced '+', exactly as in my original report.

Running instead with bash, in POSIX mode:

-#!/bin/sh
+#!/bin/bash

+set -o posix
 set -vx

no misplaced '+' is observed (as in "-type+" above):

++ find /cache_for_lmi/downloads -type f
++ xargs md5sum

The run time was materially indistinguishable:
  dash: seconds=766
  bash: seconds=771
so dash has no speed advantage in this case.

I think it would be premature to switch from dash to 'bash --posix'.
This appears to be only a sporadic formatting problem with 'dash -vx'.
(Perhaps it's this:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=567648
.) I wouldn't suppose that bash has no cosmetic problems of its own,
or has fewer defects overall than dash. And keeping the "#!/bin/sh"
shebang presumably helps shellcheck guard against portability issues.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]