[lwip-devel] [patch #6253] Added csum to struct pbuf.

[Andrey Volkov]

Follow-up Comment #13, patch #6253 (project lwip):

Hi Simon

> Why do you "calculate csum for it before I call udp_send (and do 
> it fast in asm)" instead of providing this fast asm routing as
> LWIP_CHKSUM macro? 

Since, when my app. generate udp payload, it do it directly to preallocated
buffer, and do it in asm routine, i.e. payload csum calculation is part of
payload data generation process.

> Anyway, from your description, it seems to me as one checksum
> per packet could also be sufficient...

Only and only if packet == pbuf. But in my case, for any _outgoing_ udp
packet, I need 2 pbufs in chain - first for udp/ip/eth headers (and lwip will
calculate csum for it in udp_sendto_if), second - for payload (with
precalculated csum).

Also, for each _incoming_ ethernet packet, AD BF537 MAC calculate 2 csums -
for ip header and for ip payload. So, in this case, lwip need NOT to
recalculate checksums for incoming ip packets, if driver store they somewhere
(in pbufs).

--
Andrey

P.S. Oops, I'm sorry, that don't tell it before, but I use only low level
api, so udp_send called directly from my application.


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6253>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/