|
From: | Simon Goldschmidt |
Subject: | [lwip-devel] [patch #8994] dhcp: add support for vendor specific options 43 and 60 |
Date: | Mon, 23 May 2016 08:07:51 +0000 (UTC) |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36 |
Follow-up Comment #2, patch #8994 (project lwip): The patch looks OK, but the lwIP API design should provide functions (or function-like macros) to access struct members. Applications should not access struct members directly. Although this cannot really be checked in C (unless you hide the actual struct definition, which produces bad code), could you add such a function or macro for the new struct dhcp member? _______________________________________________________ Reply to this item at: <http://savannah.nongnu.org/patch/?8994> _______________________________________________ Nachricht gesendet von/durch Savannah http://savannah.nongnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |