[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [task #14314] Implement interface name/index APIs

From: Sylvain Rochet
Subject: [lwip-devel] [task #14314] Implement interface name/index APIs
Date: Fri, 27 Jan 2017 19:26:40 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0

Follow-up Comment #24, task #14314 (project lwip):

For PPP the user can't change the init_cb netif callback. I will hit the
netif_num overflows in one of "my" product where I am recycling a previously
used PPP PCB for a GPRS backup link. (I will also hit it in PPP tests where I
am creating/freeing PPP PCB for tests purposes but that's less important.)

Therefore I am willing to add the uniqueness loop inside the ppp_netif_init_cb
function to prevent hitting it myself and having to patch lwIP… I agree we
don't need to support systems with more than let's say 10 netifs but we should
in my opinion support systems that are removing and adding netif on the fly.
If there are only a few netifs the naive loop would do the job. (Well even
with 256 netifs, looping 65536 times is meaningless actually).

The previous PPP implementation in 1.4.1 added the netif only when the link
was up and removed it when it goes down, so that's a behavior which already
existed in the stack itself. It was not wrong in my opinion, I only changed
that in order to avoid bringing down a fully established link just because the
netif could not be added, moving it to ppp_new allowed user to have an early
notification about this failure.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]