Re: [lwip-users] Default AVR32 framework LwIP input path

[Boulanger, Cyrille]

Hi Sylvain,

> By the way, I wrote a AVR32UC3 LwIP port working with the 
> current LwIP 
> HEAD revision, what's the best way to contribute this one to the 
> community ?
Best is to check the online ASF bugzilla (asf.atmel.com/bugzilla). 
Btw I found this bug (http://asf.atmel.com/bugzilla/show_bug.cgi?id=959)

(it's not the lwIP HEAD but it's probably closer to what was in the 
AVR32-SoftwareFramework-1.0.0-AT32AP7000 package).

Regards,

Cyrille.
.

> -----Original Message-----
> From: 
> address@hidden 
> [mailto:address@hidden
> org] On Behalf Of Sylvain Rochet
> Sent: Friday, April 27, 2012 5:04 PM
> To: Mailing list for lwIP users
> Subject: Re: [lwip-users] Default AVR32 framework LwIP input path
> 
> Hi,
> 
> On Fri, Apr 27, 2012 at 04:23:11PM +0200, Simon Goldschmidt wrote:
> > Sylvain Rochet <address@hidden> wrote:
> > > lwip-port/AT32UC3A/netif/ethernetif.c::ethernetif_input() 
> function from 
> > > the AVR32-SoftwareFramework-1.0.0-AT32AP7000 looks like:
> > > 
> > > static void ethernetif_input(void * pvParameters) {
> > >   -wait for macb and loop packet input, not important- {
> > >     if( ERR_OK != ethernet_input( p, netif ) ) {
> > >        -free, ..., not important-
> > > [..]
> > > I am wrong saying 
> > > that this is just defective by design and MUST be replaced by 
> > > "netif->input(p, netif)" which calls tcpip_input() and 
> put the packet on 
> > > the packet input box ?
> > 
> > That looks indeed wrong (at least when using lwIP with NO_SYS==0, 
> > which seems like what they do, seeing they pass 'tcpip_input' to 
> > 'netif_add) and your suggested fix (calling netif->input() 
> instead of 
> > ethernet_input()) is correct, yes.
> 
> Thanks for the confirmation.
> 
> So, for all of us using the Atmel AVR32 framework, we need to 
> fix this 
> design bug which might send us into deep trouble :-)
> 
> By the way, I wrote a AVR32UC3 LwIP port working with the 
> current LwIP 
> HEAD revision, what's the best way to contribute this one to the 
> community ?
> 
> Sylvain
>