[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: lynx-dev --disable-gopher, why not --disable-finger?
From: |
Webmaster Jim |
Subject: |
Re: lynx-dev --disable-gopher, why not --disable-finger? |
Date: |
Sat, 6 Mar 1999 12:00:45 -0500 |
On Fri, Mar 05, 1999 at 09:06:09PM -0500, John Bley wrote:
> Subject says it all. Well, almost. I tried to do the patch myself, but
> autoconf started throwing hissyfits, and I hate to submit untested patches.
>
> Whoever wrote the very simple DISABLE_GOPHER, could you find it in your
> heart to do DISABLE_FINGER?
That was me...
> (Implementation note: HTGopher.c calls into the HTFinger code at one
> point, be wary).
Okay, I'm attaching a cloned patch for finger. I tested it, and it will
disable gopher along with finger. Someone else will have to look at
the logic (if it's really worth it) to maintain gopher while disabling
finger. My opinion is just turn them both off and be done with it. I
verified that the gopher node at http://gopher.unicom.com:70/gn-info/
(see below).
I have uploaded the resultant configure script (for dev19) to
http://jim.spath.com/lynx/configure.txt for those who do not wish to
"autoconf." This time I'm using Tom's patches :-).
==== patch ====
*** WWW/Library/Implementation/HTFinger.c.df Wed Feb 17 09:29:33 1999
--- WWW/Library/Implementation/HTFinger.c Sat Mar 6 11:13:00 1999
***************
*** 26,31 ****
--- 26,34 ----
*/
#include <HTUtils.h>
+
+ #ifndef DISABLE_FINGER
+
#include <HTAlert.h>
#include <HTML.h>
#include <HTParse.h>
***************
*** 416,418 ****
--- 419,423 ----
#else
GLOBALDEF PUBLIC HTProtocol HTFinger = { "finger", HTLoadFinger, NULL };
#endif /* GLOBALDEF_IS_MACRO */
+
+ #endif /* not DISABLE_FINGER */
*** WWW/Library/Implementation/HTAccess.c.df Thu Mar 4 05:39:45 1999
--- WWW/Library/Implementation/HTAccess.c Sat Mar 6 11:20:58 1999
***************
*** 145,151 ****
--- 145,153 ----
extern GLOBALREF (HTProtocol, HTGopher);
extern GLOBALREF (HTProtocol, HTCSO);
#endif /* not DISABLE_GOPHER */
+ #ifndef DISABLE_FINGER
extern GLOBALREF (HTProtocol, HTFinger);
+ #endif /* not DISABLE_FINGER */
#ifdef DIRECT_WAIS
extern GLOBALREF (HTProtocol, HTWAIS);
#endif /* DIRECT_WAIS */
***************
*** 158,164 ****
--- 160,168 ----
#ifndef DISABLE_GOPHER
GLOBALREF HTProtocol HTGopher, HTCSO;
#endif /* not DISABLE_GOPHER */
+ #ifndef DISABLE_FINGER
GLOBALREF HTProtocol HTFinger;
+ #endif /* not DISABLE_FINGER */
#ifdef DIRECT_WAIS
GLOBALREF HTProtocol HTWAIS;
#endif /* DIRECT_WAIS */
***************
*** 186,192 ****
--- 190,198 ----
HTRegisterProtocol(&HTGopher);
HTRegisterProtocol(&HTCSO);
#endif /* not DISABLE_GOPHER */
+ #ifndef DISABLE_FINGER
HTRegisterProtocol(&HTFinger);
+ #endif /* not DISABLE_FINGER */
#ifdef DIRECT_WAIS
HTRegisterProtocol(&HTWAIS);
#endif /* DIRECT_WAIS */
*** configure.in.df Thu Mar 4 05:39:45 1999
--- configure.in Sat Mar 6 11:09:49 1999
***************
*** 768,773 ****
--- 768,781 ----
AC_MSG_RESULT($use_gopher)
test $use_gopher != "no" && AC_DEFINE(DISABLE_GOPHER)
+ AC_MSG_CHECKING(if you want to exclude FINGER code)
+ CF_ARG_DISABLE(finger,
+ [ --disable-finger disable FINGER logic],
+ [use_finger=yes],
+ [use_finger=no])
+ AC_MSG_RESULT($use_finger)
+ test $use_finger != "no" && AC_DEFINE(DISABLE_FINGER)
+
dnl --------------------------------------------------------------------------
dnl DirEd (directory-editor) options
*** config.hin.df Thu Mar 4 05:39:45 1999
--- config.hin Sat Mar 6 11:14:27 1999
***************
*** 17,22 ****
--- 17,23 ----
#undef DECL_STRSTR
#undef DECL_SYS_ERRLIST
#undef DIRED_SUPPORT /* AC_ARG_WITH(dired) */
+ #undef DISABLE_FINGER /* CF_ARG_DISABLE(finger) */
#undef DISABLE_GOPHER /* CF_ARG_DISABLE(gopher) */
#undef DISP_PARTIAL /* CF_ARG_ENABLE(partial) */
#undef DONT_TRACK_INTERNAL_LINKS /* CF_ARG_DISABLE(internal-links) */
==== tests ====
11:54:32/jim> ./lynx -dump gopher://gopher.unicom.com/11/gn-info
lynx: Can't access startfile gopher://gopher.unicom.com/11/gn-info
11:54:40/jim> /usr/local/bin/lynx2-8-2-dev15 -dump
gopher://gopher.unicom.com/11/gn-info
Gopher Menu
Gn is a multi-protocol information server that supports both
Gopher and World-Wide Web clients. Yes, you are using it right
now! This menu contains pointers to information about gn.
(FILE) [1]What's New in our gn info Area
(DIR) [2]The gn FAQ is in our FAQ area.
...
11:55:23/jim> /usr/local/bin/lynx2-8-2-dev15 -dump finger://stripey/jim
Finger server on stripey: jim
Login: jim Name: jim
Directory: /usr/home/jim Shell: /bin/sh
On since Sat Mar 6 10:55 (EST) on ttyv0, idle 1:00 (messages off)
On since Sat Mar 6 10:55 (EST) on ttyp0 from :0.0
On since Sat Mar 6 10:55 (EST) on ttyp1, idle 0:58, from :0.0
On since Sat Mar 6 10:58 (EST) on ttyp2, idle 0:01, from :0.0
On since Sat Mar 6 11:48 (EST) on ttyp3, idle 0:01, from :0.0
On since Sat Mar 6 11:49 (EST) on ttyp4, idle 0:05, from :0.0
No Mail.
No Plan.
Login: jspath Name: jim
Directory: /usr/home/jspath Shell: /bin/sh
Never logged in.
Mail last read Mon Sep 14 22:47 1998 (EDT)
No Plan.
Login: spath Name: jim
Directory: /usr/home/spath Shell: /bin/sh
Never logged in.
No Mail.
No Plan.
11:55:30/jim> ./lynx -dump finger://stripey/jim
lynx: Can't access startfile finger://stripey/jim
==== sizes ====
-rwxr-xr-x 1 jim wheel 966656 Mar 6 11:44 ./lynx
-rwxr-xr-x 1 jim wheel 1040384 Feb 26 05:44 /usr/local/bin/lynx2-8-2-dev15
+++++++++++++++++++++++++++++++++
Marvin the Paranoid Android says:
A brain the size of a planet and this is what I'm reduced to:
A terminal at Cardiff. How utterly depressing.
- lynx-dev --disable-gopher, why not --disable-finger?, John Bley, 1999/03/05
- Re: lynx-dev --disable-gopher, why not --disable-finger?,
Webmaster Jim <=
- Re: lynx-dev --disable-gopher, why not --disable-finger?, John Bley, 1999/03/06
- why not --disable--news (was: lynx-dev --disable-gopher, why not --disable-finger)?, Webmaster Jim, 1999/03/06
- Re: why not --disable--news (was: lynx-dev --disable-gopher, why not --disable-finger)?, Webmaster Jim, 1999/03/07
- lynx-dev Re: why not --disable-news, John Bley, 1999/03/07
- Re: lynx-dev why not --disable-news, Kim DeVaughn, 1999/03/07
- Re: lynx-dev why not --disable-news, John Bley, 1999/03/08
- lynx-dev Dead code removal (was: Re: why not --disable-news), Kim DeVaughn, 1999/03/08
- Re: lynx-dev Dead code removal, John Bley, 1999/03/08
- Re: lynx-dev Dead code removal, Kim DeVaughn, 1999/03/08
- Re: lynx-dev Dead code removal, Philip Webb, 1999/03/08