maposmatic-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH 1/3] Add a Thanks for donation page


From: Jeroen van Rijn
Subject: Re: [Maposmatic-dev] [PATCH 1/3] Add a Thanks for donation page
Date: Sun, 1 Apr 2012 19:48:05 +0200

On Sun, Apr 1, 2012 at 19:27, David MENTRE <address@hidden> wrote:
2012/4/1 Étienne Loks <address@hidden>:
> Have you tried to change the url name?
> All in all it is a good idea to change that.

I've just sent a patch. It fixes the issue for me. Hopefully I'm
fixing a real bug. :-)

Best regards,
d.


https://docs.djangoproject.com/en/dev/topics/http/urls/#naming-url-patterns

That name parameter in the url dispatcher is used for reverse lookups so that you can use that name specified there in templates.

e.g. <li {% block menu-donate %}{% endblock %}><a href="" url donate %}">{% trans "Donate" %}</a></li>

Therefore I think you did fix the bug, because the donate-thanks entry in the url dispatcher clobbered the 'donate' reverse lookup with the donate-thanks view, overwriting the donate view's link to that name as defined in the line before it.
 
Best regards,
Jeroen

--
BA[Start]


reply via email to

[Prev in Thread] Current Thread [Next in Thread]