[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: stray dot in freetds configure on OSX (was Re: Freetds (was Re: [Min
From: |
Volker Grabsch |
Subject: |
Re: stray dot in freetds configure on OSX (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed)) |
Date: |
Sun, 12 Sep 2010 19:57:38 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Tony Theodore <address@hidden> schrieb:
> On 12 September 2010 07:33, Tony Theodore <address@hidden> wrote:
> > diff -r ffaeb3439286 src/freetds.mk
> > --- a/src/freetds.mk Sat Sep 11 21:03:14 2010 +0200
> > +++ b/src/freetds.mk Sun Sep 12 07:27:39 2010 +1000
> > @@ -21,6 +21,7 @@
> > endef
> >
> > define $(PKG)_BUILD
> > + $(SED) -i 's,echo -n,printf,' '$(1)/configure.ac'
> > cd '$(1)' && NOCONFIGURE=true ./autogen.sh
> > cd '$(1)' && $(LIBTOOLIZE)
> >
> >
> > But I haven't tested it on other systems. Some other options may be
> > setting SHELL or CONFIG_SHELL, I'll look at it tomorrow.
>
> I've tried various other things, but the printf replacement seems to
> be the only one that works. It works on FreeBSD and Ubuntu also, so it
> should be safe to change.
Since this is a portability fix at a well-defined place, I think the
$(SED) construct is inappropriate here.
Would you mind reformulating it as a new patch? A good name for the
patch might be:
src/freetds-2-portability-fix.patch
or
src/freetds-2-fix-echo.patch
Also, it might be a good idea to offer this patch to the FreeTDS
project. Maybe they include it.
Greets,
Volker
--
Volker Grabsch
---<<(())>>---
Administrator
NotJustHosting GbR
- Re: freetds on FreeBSD (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed)), (continued)
Re: freetds on FreeBSD (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed)), Volker Grabsch, 2010/09/18
stray dot in freetds configure on OSX (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed)), Mark Brand, 2010/09/11
- Re: stray dot in freetds configure on OSX (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed)), Tony Theodore, 2010/09/11
- Re: stray dot in freetds configure on OSX (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed)), Tony Theodore, 2010/09/12
- Re: stray dot in freetds configure on OSX (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed)),
Volker Grabsch <=
- Re: stray dot in freetds configure on OSX (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed)), Tony Theodore, 2010/09/13
- Re: stray dot in freetds configure on OSX (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed)), Mark Brand, 2010/09/13
- Re: stray dot in freetds configure on OSX (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed)), Tony Theodore, 2010/09/13
- Re: stray dot in freetds configure on OSX (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed)), Mark Brand, 2010/09/14
Re: stray dot in freetds configure on OSX (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed)), Mark Brand, 2010/09/12