Re: freetds on FreeBSD (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed))

[Tony Theodore]

On 13 September 2010 06:32, Mark Brand <address@hidden> wrote:
>
>>> Apparently the Windows stuff in include/fakepoll.h  stating at line 67 is
>>> not included on your FreeBSD system:
>>>
>> [...]
>>>
>>> Can you figure out why? Is there a clue in config.log? I almost wonder if
>>> HAVE_POLL is getting set somehow, but your log/freetds indicates that
>>> it's
>>> not set.
>>
>> For some strange reason, autoreconf creates an empty fakepoll.h in
>> src/replacements. Removing this allows the build to proceed:
>>
>>    cd '$(1)'&&  NOCONFIGURE=true ./autogen.sh
>> + rm '$(1)/src/replacements/fakepoll.h'
>>    cd '$(1)'&&  $(LIBTOOLIZE)
>>
>> I'm sure this isn't a real solution, but I can't see how this happens.
>
> Very peculiar indeed.  I looked at the commit history and I see that
> fakepoll.h was moved from "src/replacements" to "include" in these 2 commits
> (which you can find in "freetds-src/1-fastforward.patch":
>
>> commit 4afe9204870d1aa18a9f5fada09ebb06941cba3e
>> Author: jklowden <jklowden>
>> Date:   Wed Jan 7 02:58:32 2009 +0000
>>
>>    src/replacements/fakepoll.h
>>
>> diff --git a/include/fakepoll.h b/include/fakepoll.h
>> new file mode 100644
>> index 0000000..e81f9ad
>> --- /dev/null
>> +++ b/include/fakepoll.h
>>
>> commit deab49f7bbdacfb21186e0fa86533512ab345670
>> Author: jklowden <jklowden>
>> Date:   Fri Jan 9 04:59:58 2009 +0000
>>
>>    add LIBICONV to linker flags
>>
>> diff --git a/src/replacements/fakepoll.h b/src/replacements/fakepoll.h
>> deleted file mode 100644
>> index 569b485..0000000
>> --- a/src/replacements/fakepoll.h
>> +++ /dev/null
>
> (FreeTDS uses cvs not git. I just used git to construct the patch, which is
> where the SHA1s come from.)
>
> I searched a bit for some residual reference to the old location which might
> play a role when the empty fakepoll.h reappears there. But I don't see any
> good candidates.
>
> Are you absolutely sure that it is autoreconf which is creating the empty
> file? I am starting to wonder if patch is behaving differently for you than
> for me.  When the big freetds-1-fastforward.patch is applied, there is no
> fakepoll.h left behind in the old location. Is it possible that patch just
> empties the file in your case? I have GNU patch 2.6.1.81-5b68.

That seems to be the problem, I have version 2.1. Updating that allows
the build to succeed.

The attached updates the docs and adds a new $(PATCH) variable.

Thanks for your help with this.

Tony

P.S. xz is in the base system now and there isn't a package for it.

freebsd-patch.diff
Description: Binary data