Re: [Mingw-cross-env-list] [PATCH] gtk and glib fixes (undefined references)

[Tony Theodore]

On 29 September 2010 19:43, Mark Brand <address@hidden> wrote:
>
>>>> Mark, could you add those flags to your *-1-fixes patches, please?
>>>> Or is there a better way to include them?
>>>
>>> The pc file for gio is already patched like that. That seems to be
>>> enough, or is it?
>>
>> Martin's patch also added
>>
>>     -lwinspool -lcomctl32 -lcomdlg32
>>
>> to the "Libs:" section of gtk+-2.0.pc(.in). In contrast, your patch
>> to gtk+-2.0.pc.in makes the following change:
>>
>>     -Libs: -L${libdir} address@hidden@ @GTK_EXTRA_LIBS@
>>     +Libs: -L${libdir} address@hidden@ @GTK_DEP_LIBS@
>
> Right, but in my follow-up message I mentioned some further work including
>
> http://hg.savannah.gnu.org/hgweb/mingw-cross-env/diff/4cc31fd7b9d5/src/gtk-1-fixes.patch
>
> which adds "-lwinspool -lcomctl32 -lcomdlg32" to gtk+-2.0.pc.in.
>
> (We might be suffering from delayed delivery of messages on this list.)
>
>> This leads to three questions:
>>
>> 1) Mark, are the flags "-lwinspool -lcomctl32 -lcomdlg32" already added
>>          via @GTK_DEP_LIBS@ ?
>
> No. See above.
>
>> 2) Mark, why do you remove "@GTK_EXTRA_LIBS@" from the "Libs:" section?
>
> I didn't think about or question this. This change comes from the original
> "sed" patches. Are you thinking that "-lwinspool -lcomctl32 -lcomdlg32"
> should go in via GTK_EXTRA_LIBS?

The GTK_EXTRA_LIBS are appended to GTK_DEP_LIBS when configuring.
Changing to @GTK_DEP_LIBS@ ensures all libs are included.

HTH,

Tony