mingw-cross-env-list
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Mingw-cross-env-list] Qt static codec dependencies


From: Nikos Chantziaras
Subject: Re: [Mingw-cross-env-list] Qt static codec dependencies
Date: Wed, 29 Jun 2011 23:06:11 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110624 Thunderbird/3.1.11

On 06/29/2011 03:02 PM, Mark Brand wrote:
 [...]
I think I have a good solution for this.

http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/33a76ea753c6

The static codec plugin dependencies now come automatically with
QtCore so the the user doesn't not have to worry about this for each
application.

I'd go with whatever upstream does by default. If this is a cherrypick
of an upstream Git commit, then I guess it's OK. If not, then the user
should have to worry about this for each application, because that's
what's expected with static Qt builds; cross-env should not change
expected, documented behavior.

We have a history of pushing our good ideas for static Windows Qt
upstream. :) I'm leaning toward a merge request for this one too.

I don't think this will break expected behavior. It should be harmless
for an application to be explicitly configured to use the static codec
plugins when QtCore is so configured already.

The big advantage is that users who are not even thinking about codecs
or plugins will not get surprised by a mysterious link failure just
because QtCore itself depends on them. Otherwise I'm afraid this will
become the most FAQ for mingw-cross-env.

Does this address your concerns?

I don't actually have any concerns. Just opinions :-) If it works, then it looks fine to me ;-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]