[Monotone-devel] Re: .mt-attrs formatting

[Bruce Stephens]

Richard Levitte - VMS Whacker <address@hidden> writes:

[...]

> Do you have a possibility to check that I haven't forgotten
> anything?  I'm quite short on time, so I haven't made any tests.

The code's obviously correct, as far as it goes.  I don't know whether
there's anything else which reads .mt-attrs, but I'd guess not.  It
worked on the one example I tried, so essentially it works.  It's
probably worth changing the test, too:

--- tests/t_attributes.at
+++ tests/t_attributes.at
@@ -10,7 +10,7 @@
 AT_DATA(a, [some data
 ])
 AT_DATA(.mt-attrs,
-[test_attr true foo
+[test_attr   true    foo
 test_attr 1 a
 ])

I verified that this fails before your change, and succeeds afterwards.

I considered reworking the code to allow comments, and to warn when
the regexp doesn't match, but it's probably not worth it.  99% of the
time this'll be used to make configure, autogen.sh, and similar files
executable, and the right solution for the rest is to use lua to parse
the file, not C++.