Re: [Monotone-devel] Was the great 'we don't want automatic recursion' stuff supposed to alter automate inventory'?

[Timothy Brownawell]

On Fri, 2007-03-23 at 10:37 +0000, Daniel THOMPSON wrote:
> Hi Folks
> 
> One of the users of the meld/monotone support (that allows meld to be
> used as a pre-commit graphical difference tool) has observed a whole
> bunch of warning coming out of meld.
> 
> I have traced this back to a change in the behavior of 'automate inventory'.
> 
> It appears to me that this command has (spuriously?) been caught up in
> the --recursive changes much as 'ls missing' was. Unfortunately
> 'automate inventory' does not support the --recursive option used to
> make it useful again.
> 
> Example shown below:
> 
> butch$ mtn db init --db=test.db
> butch$ mkdir localhost.branch
> butch$ cd localhost.branch/
> butch$ mtn setup --db=../test.db --branch=localhost.branch
> butch$ mkdir -p one/two/three
> butch$ touch one/two/three/four
> butch$ mtn automate inventory
>   U 0 0 one/
>   U 0 0 one/two/            <- THIS LINE MISSING IN monotone-0.33
>   U 0 0 one/two/three/      <- THIS LINE MISSING IN monotone-0.33
>   U 0 0 one/two/three/four  <- THIS LINE MISSING IN monotone-0.33
> 
> Basically is this a bug or a deliberate change in the behavior of
> 'automate inventory'?
> 
> BTW since the documentation for 'automate inventory' says it lists every
> file in the workspace and since 'automate interface_version' has not
> changed so there is definitely a bug somewhere ;-)

Yes, it's a bug. It appears to have been fixed on current mainline.

There is also a bug in the automate_inventory test, in that it doesn't
test behavior for items in subdirectories.

-- 
Timothy

Free (experimental) public monotone hosting: http://mtn-host.prjek.net