Re: [Monotone-devel] Monotone 0.42: "peer [...] IO failed in confirmed state (success)"?

[Markus Wanner]

Hello Timothy,

Markus Wanner wrote:
> Ralf S. Engelschall wrote:
>> | mtn: peer monotone.ca IO failed in confirmed state (success)
>> | mtn: successful exchange with monotone.ca
> 
> I can reproduce this on a i386 FreeBSD 6.4 and will try to hunt the bug
> - sometime this month. Thank you for reporting this.

This has to do with your changes to netsync between 0.41 and 0.42
(b0fcf9be.. by Timothy 2008-10-18, per mtn annotate). AFAICT select() is
saying the file descriptor is ready for reading, while reading from the
file descriptor returns 0 bytes. According to the man page for read(),
returning less than the requested amount of bytes is fine, only return
values < 0 signify an error. The select_tut man page clearly indicates,
that after getting zero bytes from read() or recv(), one should not call
select() on the fd anymore.

I'm not overly familiar with netsync, but tried to fix it anyway. Please
review rev. f18abebd..

Unit tests work fine on Debian sid, FreeBSD 6.4 and Gentoo 2008.0 and
the misleading error reported by Ralf has disappeared.

Regards

Markus Wanner