Re: [Monotone-devel] Monotone 0.42: "peer [...] IO failed in confirmed state (success)"?

[Zack Weinberg]

On Sun, Jan 4, 2009 at 10:22 AM, Markus Wanner <address@hidden> wrote:
> This has to do with your changes to netsync between 0.41 and 0.42
> (b0fcf9be.. by Timothy 2008-10-18, per mtn annotate). AFAICT select() is
> saying the file descriptor is ready for reading, while reading from the
> file descriptor returns 0 bytes. According to the man page for read(),
> returning less than the requested amount of bytes is fine, only return
> values < 0 signify an error. The select_tut man page clearly indicates,
> that after getting zero bytes from read() or recv(), one should not call
> select() on the fd anymore.
>
> I'm not overly familiar with netsync, but tried to fix it anyway. Please
> review rev. f18abebd..

I'm not deeply familiar with netsync myself, but it looks good to me.

zw