[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Issues with mtn commit and the latest net.venge.mo
From: |
Zack Weinberg |
Subject: |
Re: [Monotone-devel] Issues with mtn commit and the latest net.venge.monotone head |
Date: |
Sat, 7 Mar 2009 09:58:15 -0800 |
On Sat, Mar 7, 2009 at 4:59 AM, Tero Koskinen <address@hidden> wrote:
>> > When doing "mtn commit" I get:
>> > $ mtn ci
>> > mtn.real: beginning commit on branch 'fi.iki.tkoskine.ahven'
>> > mtn.real: warning: [string "<std hooks>"]:314: bad argument #1 to 'find'
>> > (string expected, got nil)
>> > mtn.real: misuse: edit of log message failed
>
> Following one line change seems to fix commit for me:
> - if (not string.find(editor, "[^%w_.+-]")) then
> + if (not string.find(exe, "[^%w_.+-]")) then
>
> Variable editor is unset if environment variable EDITOR does not exist.
> On the other hand, variable exe should always have some value.
Yeah, that's clearly the right fix. Committed and pushed. Could you
please try to write an automated test case for this?
zw