Re: [Monotone-devel] Issues with mtn commit and the latest net.venge.monotone head

[Zack Weinberg]

On Sun, Mar 8, 2009 at 1:11 PM, Tero Koskinen <address@hidden> wrote:
>
> Test below. I had to overwrite test_hooks.lua, because the default
> version overwrites the edit_comment function and without it I cannot
> really do the test. :)
>
> (This means that changes to the default test_hooks.lua might need
> to be copied into this test also, but hopefully that doesn't
> happen often.)

Yeah, I think we can live with that.

> The test works by overwriting execute and program_exists_in_path
> functions and using "editor" as the default editor.

I had more in mind that you would create a separate shell script named
"editor" and add the test directory to the PATH, but this doesn't
require a separate Windows implementation so actually it's better.

Some nits:

> +unset_env("EDITOR")
> +unset_env("VISUAL")

These should be in testlib.lua along with the other environment
variable clearing; we don't want to have any tests that depend on them
being set.

> +function my_execute(path,...)

I think you can just do

function execute(path,...)

and then you don't need the "execute = my_execute" later...

> +function get_revision_cert_trust(signers, id, name, val)
> +function get_manifest_cert_trust(signers, id, name, val)
> +function get_file_cert_trust(signers, id, name, val)
> +function get_passphrase(keyid)
> +function persist_phrase_ok()
> +function get_author(branchname)
> +function get_mtn_command(host)

Please take out as many of these as possible, to minimize sync burden.

zw