Re: [Nano-devel] [PATCH 2/3] silence unused shush warning

[Mike Frysinger]

On Sunday 06 November 2011 18:06:22 Eitan Adler wrote:
> On Sun, Nov 6, 2011 at 5:46 PM, Mike Frysinger wrote:
> > On Sunday 06 November 2011 16:32:03 Eitan Adler wrote:
> >> On Sun, Nov 6, 2011 at 12:51 PM, Mike Frysinger wrote:
> >> > Newer gcc warns about set-but-unused variables, so add a dummy if()
> >> > check to kill that off.
> >> 
> >> Please don't do this. It is better to check shush each time for -1.
> > 
> > the code intentionally does this.  the comment explains why.
> 
> I forgot about that. IMHO this version makes clearer what is going on:
> 
> +       (void) chmod(retval, die_stat->st_mode);
> +       (void) chown(retval, die_stat->st_uid, die_stat->st_gid);

this doesn't actually work though.

nano.c: In function ‘die_save_file’:
nano.c:713:2: warning: ignoring return value of ‘chown’, declared with 
attribute warn_unused_result [-Wunused-result]
-mike

signature.asc
Description: This is a digitally signed message part.