nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] Updated FIX for undo/redo


From: Benno Schulenberg
Subject: Re: [Nano-devel] Updated FIX for undo/redo
Date: Wed, 23 Apr 2014 18:08:31 +0200

On Wed, Apr 23, 2014, at 7:58, Mark Majeres wrote:
> I updated the undo/redo patch.  Patch was created against svn rev.4808

Thanks for that.  I've testdriven your patch a bit, and so far it looks good:
I can't find anything going wrong.  And it seems to me you haven't just
fixed the paste-undo things, but everything related to undoing/redoing cut
and uncut.  Great!

I'll test your patch for a week or so, and if I can't find any hitches, I'll 
clean
it up (whitespace issues) and apply it.

> It turned into a lot more editing than I anticipated.

Yeah, I foresaw that.  :)

> I plugged a mem leak in rcfile.c too.

Two even, if I'm not mistaken.  I'll apply those separately from the
undo/redo fixes.  But... shouldn't this globfree() be outside of the if,
shouldn't it be freed also when the condition of the if is false?

Regards,

Benno

-- 
http://www.fastmail.fm - The way an email service should be




reply via email to

[Prev in Thread] Current Thread [Next in Thread]