Re: [Nano-devel] [PATCH] bug #48501: [Request] add the ability to paste at the prompt

[Benno Schulenberg]

Op 23-07-2017 om 18:50 schreef Rishabh Dave:
> should we display the shortcut at all prompt menus?

No.  Is ^K shown in any prompt menu?  Or Backspace, etcetera?

> Usually,
> it is obvious for GUI programs that paste/uncut works at prompts.So, I
> haven't done that.

Good.

> > And please drop
> > the DEBUG stuff,
>
> Done. But may I ask why? I find it useful.

While working on something, it can be useful, but once things work,
it is just clutter in the code.  If this was something complicated,
that could go wrong in many ways, one might leave it in for a couple
of releases, but this is fully straightforward.

> Attached patch is signed and but the commit message it very short
> (infact, redundant). Should I describe anything more?

No.  But mention the request on Savannah that it fulfills.

Now to the patch:

+    add_to_sclist((MMOST & ~MBROWSER & ~MLINTER & ~MSPELL) | MYESNO,
+                       "^U", 0, do_uncut_text, 0);
+    add_to_sclist((MMOST & ~MBROWSER & ~MLINTER & ~MSPELL) | MYESNO,
+                       "F10", 0, do_uncut_text, 0);

You correctly exclude the browser and linter menus.  But why do you
exclude the (internal) speller menu?  Of course: it will be highly
unlikely that someone wants to replace a misspelled word with something
from the cutbuffer, but why forbid it?  And why do you include the
Yes-No menu?  Nothing can be pasted there, no text can be input, one
can only type Y or N or A (or their translations) or ^C.  Further,
you don't exclude the help menu.  But that doesn't matter: it is not
necessary to exclude the browser and linter menus either because they
simply ignore the Uncut function.  Or did you exclude them with a
reason?

The rest of the patch looks okay.  Although: it's not necessary to
initialize fusion to NULL.

Benno