Re: [Nano-devel] [PATCH] Implement multiple buffer count display

[Marco Diego Aurélio Mesquita]

On Sat, Sep 2, 2017 at 8:01 AM, Benno Schulenberg <address@hidden> wrote:
>
> Op  2-09-2017 om 00:43 schreef Marco Diego Aurélio Mesquita:
>>
>> The attached path should address your complaints.
>
>
> Well, you placed the titlebar(NULL) call in the wrong place -- not
> where I suggested you put it in my first answer.
>

Yes, I did it because when I've put it where you told, nano crashed.
I'm not sure why it happened. Probably my fault.

> Furthermore, you use 'openfile->prev' instead of simply 'openfile'
> to determine the sequence number of the current buffer, which means
> that the first file is shown as [n/n] instead of [1/n].
>

I was aware of it, but didn't think of it as problem. I do not oppose
this fix. Thanks!

> I've adjusted those things, plus some renames and other tweaks, in
> the attached patch.  I've also suppressed the display when in the
> file browser.  Please check if you are okay with it.
>

I'm entirely ok with it.

>
> And for others: is it okay to replace nano's name and version number
> with a [1/15] (for example) buffer count?
>

I like the way it is now: only display branding when only one buffer
is open. The only other thing that I would improve is to remove the
"File: " in the titlebar since there's some agreement that is no
longer needed and would save some space.

Now... would you mind to review my other patch? :)

Thanks!