nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] Implement multiple buffer count display


From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] Implement multiple buffer count display
Date: Sun, 3 Sep 2017 22:17:21 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1


Op  2-09-2017 om 16:28 schreef Marco Diego Aurélio Mesquita:
On Sat, Sep 2, 2017 at 8:01 AM, Benno Schulenberg <address@hidden> wrote:
Well, you placed the titlebar(NULL) call in the wrong place -- not where I suggested you put it in my first answer.

Yes, I did it because when I've put it where you told, nano crashed. I'm not sure why it happened.

Most likely you missed the 'if (!inhelp)'.

I've adjusted those things, plus some renames and other tweaks, in the attached patch. I've also suppressed the display when in the file browser. Please check if you are okay with it.

I'm entirely ok with it.

Good.

The only other thing that I would improve is to remove the "File: " in the titlebar since there's some agreement that is no longer needed and would save some space.

Yes, I will do that later, and suppress nano's name and version number
entirely in the file browser.  But it's unneeded for the current patch.

Now... would you mind to review my other patch? :)

Later.  No time.  Other things to do.

Benno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]