Re: [Nano-devel] [PATCH 1/2] display: replace the "$" continuation character with ">" and "<"

[Benno Schulenberg]

Op 07-02-19 om 21:22 schreef David Ramsey:
> Although some of the comments aren't updated by this patch, and
> spotlight() isn't switched from "$" to ">" either.
> 
> The attached patch against it should fix these.

Thanks.  With two comments below.

> (The second patch also needs to be updated to display spotlight()'s ">"
> in reverse video, but I don't have time to do that right now.)

Haven't looked at that yet.  Short on time.

>       /* If the first character starts before the left edge, or would be
> -      * overwritten by a "$" token, then show placeholders instead. */
> +      * overwritten by a "<" or ">" token, then show placeholders instead. */

The first character of a row can ever only be replaced with "<", not with ">".

> -     /* If there is more text than can be shown, make room for the $ or >. */
> +     /* If there is more text than can be shown, make room for the ">" or 
> "]". */

Room is made for just the ">".  When this 'room making' removes a double-width
character, the extra room is filled with a "[" placeholder.

Benno

signature.asc
Description: OpenPGP digital signature