Re: [Nmh-workers] [nmh-1.2] a serious bug in the nmh configure script

[Joel Reicher]

> In message <address@hidden>, Joel Reic
> her writes:
> > 
> > Something like this is what's required.
> [...]
> > 
> > But I'm not sure how well this works for other platforms and situations.
> > That's why I wrote what I did in my previous emails.
> 
> Your patch applies cleanly to the configure script provided by
> default in the source code tarball:
> 
> $ patch < ../configure.patch  
> Hmm...  Looks like a unified diff to me...
> The text leading up to this was:
> --------------------------
> |--- configure.orig     2005-12-21 18:55:37.000000000 +0100
> |+++ configure  2005-12-21 18:57:03.000000000 +0100
> --------------------------

I don't know what you did, but the patch as I posted it can't be applied
to configure. It's for configure.in and aclocal.m4, and configure needs
to be regenerated and then run.

A patch for configure would have to be

--- configure.orig      2005-12-20 15:37:46.000000000 +1100
+++ configure   2005-12-24 00:38:23.000000000 +1100
@@ -8036,7 +8036,7 @@
 
 
 
-for ac_header in db1/ndbm.h gdbm/ndbm.h db.h
+for ac_header in db1/ndbm.h ndbm.h gdbm/ndbm.h db.h
 do
 as_ac_Header=`echo "ac_cv_header_$ac_header" | $as_tr_sh`
 if eval "test \"\${$as_ac_Header+set}\" = set"; then
@@ -8188,7 +8188,7 @@
 
 
 
-if test "x" == "x"; then
+if test "x" = "x"; then
    nmh_libs=
       nmh_testname=libc
 else
@@ -8213,6 +8213,9 @@
 #ifdef HAVE_DB1_NDBM_H
 #include <db1/ndbm.h>
 #else
+#ifdef HAVE_NDBM_H
+#include <ndbm.h>
+#else
 #ifdef HAVE_GDBM_NDBM_H
 #include <gdbm/ndbm.h>
 #else
@@ -8224,6 +8227,7 @@
 #endif
 #endif
 #endif
+#endif
 
 int
 main ()

> ...but the problem remains.  slocal.c is not able to find the right
> header file yet:

Either you didn't adapt the patch correctly, or you didn't rerun
configure.

> If you want access to a NetBSD machine to do some tests let me know.

I'm using a NetBSD machine.

Cheers,

        - Joel