[Octave-bug-tracker] [bug #44219] Deleted GUI file editor tabs not forgotten upon command line "exit"

[Torsten]

Follow-up Comment #4, bug #44219 (project octave):

IMHO having two separate routines for saving and closing does not solve the
following conflict when exiting the application via the gui (Ctrl-Q, Alt-F4,
...):

* We have to save the session and check whether possible modifications have to
be saved or discarded, or whether the user wants to cancel exiting
* When the user definitely wants to exit, we call octave to exit via Fquit
* Now we are entering the same path as if "exit" was entered into the console
(where saving session and checking for modifications have to be done, too) and
we have to prevent that in our case (gui exit),
** we save the session again but with already closed files or
** we still have unchanged files open and ask the user again if modifications
have to be saved

I have attached a patch that at least does not need to call check_closing from
the editor's destructor. But still there is a flag indicating that exiting was
initiated by the gui. However, it is really possible that I got stuck in my
way of viewing the problem and there is a much more elegant solution.



(file #33057)
    _______________________________________________________

Additional Item Attachment:

File name: check_exit_20140212.patch      Size:2 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?44219>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/