octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #45369] pkg build leads to duplication of PKG_


From: Philip Nienhuis
Subject: [Octave-bug-tracker] [bug #45369] pkg build leads to duplication of PKG_ADD and PKG_DEL files
Date: Tue, 23 Jun 2015 15:46:38 +0000
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 SeaMonkey/2.33

Follow-up Comment #6, bug #45369 (project octave):

I like Olaf's suggestion the most:

Simply let package maintainers/developers put PKG_ADD / PKG_DEL in the most
suitable directory (arch-independent or-dependent) for a certain package, and
let pkg.m just copy it over.
* Easy to grasp for developers;
* No need for maintenance of maybe fragile code for parsing and extracting of
stuff from comments;
* PKG_ADD / PKG_DEL are easily tracked. What if some function containing
PKG_ADD/PKG_DEL is removed from a package, or if functions accidentally
containing PKG_* commented code are moved between packages?
* It is simpler and more clean. I do not like to have special code in a
function file that needs to be there for purposes the function itself isn't
meant for. (Carnë suggested to have PKG_ADD/PKG_DEL in one particular .m-file
in the io package)

Even better (as Olaf also mentions) would be if pkg.m could be adapted such
that PKG_ADD & PKG_DEL are only invoked after the entire package is loaded.
Is there a certain and consistent order in which the arch-dependent and
arch-independent directories are loaded? (E.g., for the io package it is
always the arch-independent one that is loaded last.)
If so I'd suppose pkg.m could simply be patched to put PKG_* in the directory
that is loaded lastly rather than always in the arch-dependent one.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45369>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]