[Octave-bug-tracker] [bug #38085] image package: fails to build with --enable-64 (entropyfilt)

[JoséGarcía]

Follow-up Comment #11, bug #38085 (project octave):

Good evening to everyone,

On May we were trying to get a "linux 64bit integer build" to work with image
package.

We were facing problems during the last 2 years with those kind of octave
builds. It was pointed out by Jordi G.H. to make some changes in the 
_spatial_.cc code.

My mistake;  at the moment of calling "make dist" to create the image.*.tar.gz
it was not picking the _spatial_.cc that was modified. It is the first
octave-forge package that we have edited and I was not capable of seeing that
behaviour.

Anyway, I retried as Jordi explained, but it was also failing
 the same way, saying again about "ambiguous conversion". I'm not too much
into programming so I tried to force to convert those entities into standard
ANSI C "int" variable.


After some trials, it was possible to get the code to compile on Linux amd64 +
gcc-4.9.2 changing those two lines to: 




hist (((int)((int)(vals (i)))) + ((int)add)) ++;


hist ((((int)(int)(vals (i)))) + ((int)add)) /= (double)len;


Those changes seem acceptable?
We have tried with bwlabeln, bwconncomp, labelmatrix and others, and the
system has not failed.
As additional info, using bwlabeln needs 19 Gbytes of working mem RAM to be
capable of processing 1,3 GigaVoxel grayscale (uint8) data. bwconncomp ++
labelmatrix needs "only" 5 Gbytes. Does it seem reasonable? 

If You feel like there are other tests or changes that should be done, please
let me know.

Thanks, yours sincerely Jose


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?38085>

_______________________________________________
  Mensaje enviado vía/por Savannah
  http://savannah.gnu.org/