[Octave-bug-tracker] [bug #45369] pkg build leads to duplication of PKG_ADD and PKG_DEL files

[Julien Bect]

Follow-up Comment #20, bug #45369 (project octave):

>> 5) When building a binary package, copy PKG_ADD/PKG_DEL
>> directives into PKG_ADD/PKG_DEL files (this is what we
>> already do) but leave the resulting files where they are
>> (in particular, do not move them at the root of the tarball)
>>
>> 6) When installing a binary package, do not copy
>> PKG_ADD/PKG_DEL directives into PKG_ADD/PKG_DEL files a
>> second time (once is enough !)
>
> This requires pkg() knowing if it's installing a binary
> package or not and adds extra logic dependent on the type
> of installation. Ideally, we would keep differences to
> the minimum. Maybe the opposite is better, to not have
> binary distributions handling PKG_ADD at all, and leave
> that job for the actual pkg install.
> Problem is, a binary install no longer has the source.

You're right, my initial idea doesn't work well.

What about this:

1) When building a binary package, only process PKG_ADD/PKG_DEL directives
located in C++ source files.

2) When installing a package, process all directives found in the package.

If the src directory is removed form the binary tarball (as is currentl done)
then I think this prevents directives from being processed twice, doesn't it
?

With this approach, 'pkg install' doesn't need to know the difference between
source and binary tarballs.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45369>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.gnu.org/