[Octave-bug-tracker] [bug #43925] isscalar behaves incorrectly for some user-defined classes

[Lachlan Andrew]

Follow-up Comment #10, bug #43925 (project octave):

Thanks.  I was just about to say that the  sz(0) >= 0 was introduced in
changeset 00e31f316a3a, with the change


-      octave_value arg = args(0);
-
-      retval = arg.is_matrix_type ()
-               || arg.is_scalar_type ()
-               || arg.is_range ();
+      dim_vector sz = args(0).dims ();
+      retval = (sz.length () == 2) && (sz(0) >= 0) && (sz(1) >= 0);


I forgot to update the unit tests.  That is a habit I should get into with all
patches, I suppose.  Is there anything else I can help with on this, or should
I leave it to you?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?43925>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/