[Octave-bug-tracker] [bug #48439] validateattributes throws errors without IDs

[Carnë Draug]

Follow-up Comment #8, bug #48439 (project octave):

Asking for a review after you push is not really how this is supposed to
work.

Anyway, this cset actually changes two things on the code:

* error ids when validateattributes is called incorrectly.
* error ids for the errors that validateattributes is supposed to thrown when
called correctly.

Why are the ids for them different? If we "bless" the errors ids of the second
set, then surely we should use them on the first set. In that case they are
the same, and "Octave:invalid-invalid-type" should be changed to whatever it
is that makes the input fail. I guess that validateattributes should use
validateattributes.

Also, this should be definitely be documented somewhere.  Not sure where
though. On the error_ids page and validateattributes making reference to it?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48439>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/