[Octave-bug-tracker] [bug #53830] File Editor that is hidden reappears to check for unsaved files before quitting

[Dan Sebald]

URL:
  <http://savannah.gnu.org/bugs/?53830>

                 Summary: File Editor that is hidden reappears to check for
unsaved files before quitting
                 Project: GNU Octave
            Submitted by: sebald
            Submitted on: Fri 04 May 2018 06:41:29 AM UTC
                Category: GUI
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Incorrect Result
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: Any

    _______________________________________________________

Details:

For a long while I've noticed something happening at exit with regard to
layout changing.  I've now realized what this is.  The File Editor window
comes to the top of a the widget stack, or more blatantly will reappear before
closing if it is hidden.  Unfortunately, it appears the order of

1) Check for unsaved files
2) The re-emergence of the File Editor window
3) Saving of the settings via aboutToQuit

is such that the saved geometry settings happen after the File Editor
reappears so that the next time the window is opened the File Editor is no
longer hidden.

Try the following:

1) Move octave_dock_widget panels about in such a way that the File Editor is
isolated in its own region, no tab stack.
2) Now (without having edited any files...but the <unnamed> tab is still
present) hide the File Editor.
3) In the Command Window type "exit" and notice the File Editor will reappear
just before exit.
4) Rerun Octave and notice the File Editor window is present.

Then try a slight variation:

1) Move octave_dock_widget panels about in such a way that the File Editor is
isolated in its own region, no tab stack.
2) Now, without having edited any files, *close* the <unnamed> tab in the File
Editor.
3) Hide the File Editor.
4) In the Command Window type "exit" and notice that this time the File Editor
window does not appear just before close.
5) Rerun Octave and notice the File Editor window is *not* present.

So, presumably it is the process of checking whether the files are unsaved
(provided at least one file is present) that is causing the File Editor to
appear.

But it isn't obvious exactly how this is happening.  Try another slight
variation on this

1) Move octave_dock_widget panels about in such a way that the File Editor is
isolated in its own region, no tab stack.
2) This time type some characters in the <unnamed> tab window in the File
Editor but *do not save*.
3) Hide the File Editor.
4) In the Command Window type "exit" and the dialog box will appear asking
whether the file should be saved...but the File Editor hasn't reappeared just
yet.
5) Select "Close without Saving"; then the File Editor appears just before
close.
6) Rerun Octave and notice the File Editor window is present.

I would say that the order should be something like:

1) Save the geometry to settings file.
2) Check for any files that are unsaved.
3) No hidden File Editor should appear, unless an unsaved file is present.
4) If unsaved file, make the File Editor reappear and bring the unsaved file
into focus so that the user can see what it is while the dialog is present.
5) Repeat for any more unsaved files, then exit.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53830>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/