[Octave-bug-tracker] [bug #56097] unlink ("filename") hangs GUI

[Rik]

Follow-up Comment #36, bug #56097 (project octave):

@jwe: Your solution would future proof Octave if another editor is ever added.
 On the negative side, it substitutes a compile-time test with a run-time test
so there are potential performance concerns.  I don't know whether this is a
legitamate concern or not since the GUI operates at human time scales which
are pretty slow.

If we wanted to preserve the compile-time test then we could change the code
to use a more generic conditional such as HAVE_GUI_EDITOR and then in
configure.ac there could be a single line


#define HAVE_GUI_EDITOR (HAVE_QSCINTILLA || HAVE_OTHER_EDITOR1 ||
HAVE_OTHER_EDITOR2)


I did not close this report since there is this remaining question open about
future proofing the code.  Changes for this issue should be made on the
development branch, not the stable branch.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?56097>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/