octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: MSVC compiler support [patch 33]: Help


From: michael . goffioul
Subject: RE: MSVC compiler support [patch 33]: Help
Date: Thu, 26 Oct 2006 16:21:28 +0200

> I won't apply this patch unless I know why it is needed, and even
> then, I think we should find some solution other than disabling help
 
Basically, the problem was I had was a crash due to the setvbuf problem.
At that moment, I didn't setvbuf was crashing, so I disabled the code.
If sed and makeinfo are available the code works OK, except that the
sed for Windows (GnuWin32 package) uses double-quotes and not
single-quote; hence the following patch:
 
Index: src/help.cc
===================================================================
RCS file: /cvs/octave/src/help.cc,v
retrieving revision 1.165
diff -c -p -r1.165 help.cc
*** src/help.cc 16 Aug 2006 06:52:19 -0000      1.165
--- src/help.cc 26 Oct 2006 14:20:57 -0000
*************** display_help_text (std::ostream& os, con
*** 779,785 ****
--- 779,789 ----
 
        std::ostringstream buf;
 
+ #ifndef _MSC_VER
        buf << "sed -e 's/^[#%][#%]* *//' -e 's/^ *@/@/' | "
+ #else
+       buf << "sed -e \\"s/^[#%][#%]* *//\\" -e \\"s/^ *@/@/\\" | "
+ #endif
          << "\\"" << Vmakeinfo_program << "\\""
          << " -D \\"VERSION " <&! lt; OCTAVE_VERSION << "\\""
          << " -D \\"OCTAVEHOME " << OCTAVE_PREFIX << "\\""

 
Michael.
 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]