Re: MSVC 2.9.12-3: "mkoctfile" still fails when it is intalled to the folder the full path of which include white space.

[Michael Goffioul]

On 6/6/07, Tatsuro MATSUOKA <address@hidden> wrote:
> *******************************************
> D:\usr\Tatsu\program\Octave\test>mkoctfile hello.cc
> cl : Command line warning D9024 : unrecognized source file
> type 'Files\Octave2.9.12-3\include\octave-2.9.12', object
> file assumed

I fixed this now. Thanks.

Note that there's still a bug in mkoctfile.m that prevents mkoctfile to work
from octave prompt, but this is to be fixed in octave's code, see the following
patch.

Michael.

Index: scripts/miscellaneous/mkoctfile.m
===================================================================
RCS file: /cvs/octave/scripts/miscellaneous/mkoctfile.m,v
retrieving revision 1.7
diff -c -p -r1.7 mkoctfile.m
*** scripts/miscellaneous/mkoctfile.m   25 Apr 2007 04:27:16 -0000      1.7
--- scripts/miscellaneous/mkoctfile.m   6 Jun 2007 08:31:06 -0000
*************** function mkoctfile (varargin)
*** 126,132 ****

   shell_script = fullfile (bindir, sprintf ("mkoctfile-%s", OCTAVE_VERSION));

!   cmd = shell_script;
   for i = 1:nargin
     cmd = strcat (cmd, " ", varargin{i});
   endfor
--- 126,132 ----

   shell_script = fullfile (bindir, sprintf ("mkoctfile-%s", OCTAVE_VERSION));

!   cmd = strcat ("\"", shell_script, "\"");
   for i = 1:nargin
     cmd = strcat (cmd, " ", varargin{i});
   endfor