octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Why does "mesh " set surface "facecolor" to "none"?


From: John W. Eaton
Subject: Re: Why does "mesh " set surface "facecolor" to "none"?
Date: Thu, 08 Nov 2007 16:27:16 -0500

On  8-Nov-2007, Kai Habel wrote:

| Michael Goffioul schrieb:
| > Matlab sets it to [1 1 1] by default, which looks better.
| >
| > Other remarks concerning "mesh":
| > 1) axes properties ("view") should only be changed if the axes object
| > is not in hold mode (that is gca.nextplot is not "add")
| > 2) box should be disabled and grid should be enabled (again only in
| > non-hold mode)
| >
| > The above remarks actually applies to any standard function producing
| > 3D plots (surf, mesh, bar3...).
| >
| > Michael.
| >
| >   
| For the other remarks I propose the attached patches.

| --- mesh.m    2007-11-08 22:05:56.000000000 +0100
| +++ mesh.m.new        2007-11-08 22:04:27.000000000 +0100
| @@ -41,7 +41,9 @@
|    set (tmp, "facecolor", "none");
|    set (tmp, "edgecolor", "flat");
|  
| -  set (ax, "view", [-37.5, 30]);
| +  if (!strncmp(get(ax,"nextplot"),"add",3))
| +    set (ax, "view", [-37.5, 30]);
| +  endif
|  
|    if (nargout > 0)
|      h = tmp;

I think it would be better to use

  if (ishold ())
    ...
  endif

Will you please make that change and send the patch again?

Thanks,

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]