Re: 2.9.19??

[Michael Goffioul]

On 12/10/07, John W. Eaton <address@hidden> wrote:
> On  9-Dec-2007, David Bateman wrote:
>
> | I'm in the process of trying to create a release of octave-forge for
> | 2.9.18. However, with the documentation text image build issue and the
> | plot axis miscalculation it seems that 2.9.18 has a couple of really bad
> | issues. So I wonder if a rapid 2.9.19 release before I finalize an
> | octave-forge release wouldn't be a good idea?
>
> I'll try to make a new snapshot by Monday afternoon (US Eastern time).

Could you then consider the following patch? This relates to the following
thread:

http://www.nabble.com/Problem-with-__plt_get_axis_arg__.m-to14106356.html

I'd like to propose the same for the patch function, but I'm still waiting
for a feddback from David (or anybody else concerned) about the clim
explicit setting.

Index: scripts/plot/__line__.m
===================================================================
RCS file: /cvs/octave/scripts/plot/__line__.m,v
retrieving revision 1.4
diff -c -p -r1.4 __line__.m
*** scripts/plot/__line__.m     12 Oct 2007 21:27:24 -0000      1.4
--- scripts/plot/__line__.m     10 Dec 2007 09:09:58 -0000
*************** function h = __line__ (p, varargin)
*** 47,63 ****
      print_usage ("line");
    endif

!   h = __go_line__ (p);
!
    if (num_data_args > 1)
!     set (h, "xdata", varargin{1}, "ydata", varargin{2});
      if (num_data_args == 3)
!       set (h, "zdata", varargin{3});
      endif
    endif

    if (nvargs > num_data_args)
!     set (h, varargin{num_data_args+1:end});
    endif

  endfunction
--- 47,65 ----
      print_usage ("line");
    endif

!   data_args = {};
    if (num_data_args > 1)
!     data_args(1:4) = { "xdata", varargin{1}, "ydata", varargin{2} };
      if (num_data_args == 3)
!       data_args(5:6) = { "zdata", varargin{3} };
      endif
    endif

+   other_args = {};
    if (nvargs > num_data_args)
!     other_args = varargin(num_data_args+1:end);
    endif

+   h = __go_line__ (p, data_args{:}, other_args{:});
+
  endfunction
Index: scripts/plot/surface.m
===================================================================
RCS file: /cvs/octave/scripts/plot/surface.m,v
retrieving revision 1.11
diff -c -p -r1.11 surface.m
*** scripts/plot/surface.m      29 Nov 2007 19:07:29 -0000      1.11
--- scripts/plot/surface.m      10 Dec 2007 09:09:58 -0000
*************** function [h, bad_usage] = __surface__ (a
*** 143,158 ****

    if (! bad_usage)
      ## Make a default surface object.
!     h = __go_surface__ (ax, "xdata", x, "ydata", y, "zdata", z, "cdata", c);
!     set (h, "facecolor","flat");
      if (firststring < nargin)
!       set (h, varargin{firststring:end});
!      endif

!      if (! ishold ())
!        set (ax, "view", [0, 90], "box", "off", "xgrid", "on",
            "ygrid", "on", "zgrid", "on");
!      endif
!    endif

  endfunction
--- 143,159 ----

    if (! bad_usage)
      ## Make a default surface object.
!     other_args = {};
      if (firststring < nargin)
!       other_args = varargin(firststring:end);
!     endif
!     h = __go_surface__ (ax, "xdata", x, "ydata", y, "zdata", z,
"cdata", c, ...
!       "facecolor", "flat", other_args{:});

!     if (! ishold ())
!       set (ax, "view", [0, 90], "box", "off", "xgrid", "on",
            "ygrid", "on", "zgrid", "on");
!     endif
!   endif

  endfunction


scripts/ChangeLog

2007-12-10  Michael Goffioul <address@hidden>

    * plot/__line__.m plot/surface.m: call __go_xxx__ functions with all
    initial property/value pairs instead of using the "set" function