octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Text extent implemented (partially)


From: Jaroslav Hajek
Subject: Re: Text extent implemented (partially)
Date: Wed, 10 Mar 2010 12:15:19 +0100

On Wed, Mar 10, 2010 at 1:08 AM, Søren Hauberg <address@hidden> wrote:
> søn, 07 03 2010 kl. 21:05 +0000, skrev Michael Goffioul:
>> I've pushed the following changeset:
>>
>> http://hg.savannah.gnu.org/hgweb/octave/rev/9f2bf537a651
>
> I just noticed the following warning
>
>        graphics.h:4049: warning: declaration of 'scale' shadows a
>        member of 'this'
>        graphics.cc: In member function 'void
>        text::properties::update_text_extent()':
>        graphics.cc:4251: warning: declaration of 'extent' shadows a
>        member of 'this'
>
> which I guess is coming from your change.
>
> Søren
>
>

I'm not much in favor in "fixing" these pedantic warnings. Shadowing a
class member in a method where it is not needed is perfectly
legitimate IMHO.

-- 
RNDr. Jaroslav Hajek, PhD
computing expert & GNU Octave developer
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz



reply via email to

[Prev in Thread] Current Thread [Next in Thread]