octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Using copysignf modules from gnulib


From: Michael Goffioul
Subject: Re: Using copysignf modules from gnulib
Date: Thu, 20 Oct 2011 10:50:46 +0100

On Wed, Oct 19, 2011 at 1:19 PM, Michael Goffioul
<address@hidden> wrote:
> Hi,
>
> Octave currently uses the copysign module from gnulib, but not the
> copysignf one. It's easy to add it, but then comes a problem in
> lo-mappers.h. Because of inline implementations of xcopysign and
> xcopysignf, the gnulib replacements should be visible from that
> header, meaning we'd have to expose gnulib internals in the API. I
> guess we don't want to do that. The other solution would be to move
> implementation of xcopysign and xcopysignf in the source file. Would
> that be an acceptable solution?

Something like the attached patch. Would it be ok to push it?

Michael.

Attachment: gnulib_copysignf
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]