Re: ghull -2011. give errors

[Tatsuro MATSUOKA]

Hello

--- On Thu, 2011/12/15, John W. Eaton wrote:

> On 14-Dec-2011, marco atzeri wrote:
> 
> | On 12/14/2011 10:25 PM, Tatsuro MATSUOKA wrote:
> | > Hello
> | >
> | > I have tried to build octave with qhull -2011 on then mingw platform.
> | > For the qhull -2010,  fntests goes well without FAIL.
> | > However with qhull -2011 gives errors in fntests., for example,
> | >
> | >
> | > #****************************************************
> | >>>>>> processing 
> e:\usr\Tatsu\mingwhome\octaves\hg\octave-work\src\DLD-FUNCTIONS\convhulln.cc
> | >    ***** testif HAVE_QHULL
> | >   cube = [0 0 0;1 0 0;1 1 0;0 1 0;0 0 1;1 0 1;1 1 1;0 1 1];
> | >   [h, v] = convhulln (cube);
> | >   assert (size (h), [6 4]);
> | >   h = sortrows (sort (h, 2), [1:4]);
> | >   assert (h, [1 2 3 4; 1 2 5 6; 1 4 5 8; 2 3 6 7; 3 4 7 8; 5 6 7 8]);
> | >   assert (v, 1, 10*eps);
> | > !!!!! test failed
> | > assert (size (h),[6, 4]) expected
> | >     6   4
> | > but got
> | >     0   3
> | > values do not match
> | >    ***** testif HAVE_QHULL
> | >   cube = [0 0 0;1 0 0;1 1 0;0 1 0;0 0 1;1 0 1;1 1 1;0 1 1];
> | >   [h, v] = convhulln (cube, "QJ");
> | >   assert (size (h), [12 3]);
> | >   assert (sortrows (sort (h, 2), [1:3]), [1 2 4; 1 2 5; 1 4 5; 2 3 4; 2 3 
> 6; 2 5 6; 3 4 8; 3 6 7; 3 7 8; 4 5 8; 5 6 8; 6 7 8]);
> | >   assert (v, 1.0, 1e6*eps);
> | > !!!!! test failed
> | > assert (size (h),[12, 3]) expected
> | >     12    3
> | > but got
> | >     0   3
> | > values do not match
> | >    ***** testif HAVE_QHULL
> | >   tetrahedron = [1 1 1;-1 -1 1;-1 1 -1;1 -1 -1];
> | >   [h, v] = convhulln (tetrahedron);
> | >   h = sortrows (sort (h, 2), [1 2 3]);
> | >   assert (h, [1 2 3;1 2 4; 1 3 4; 2 3 4]);
> | >   assert (v, 8/3, 10*eps);
> | > !!!!! test failed
> | > assert (h,[1, 2, 3; 1, 2, 4; 1, 3, 4; 2, 3, 4]) expected
> | >     1   2   3
> | >     1   2   4
> | >     1   3   4
> | >     2   3   4
> | > but got
> | > [](0x3)
> | > Dimensions don't match
> | > #****************************************************
> | >
> | > Does anyone try to build with qull-2011?
> | > I would like to know whether the above behavior is mingw specific or not.
> | >
> | > Regards
> | >
> | > Tatsuro
> | 
> | It is not mingw specific, 2011 has some changes that caused
> | unexpected behaviour.
> | 
> | 
> https://mailman.cae.wisc.edu/pipermail/octave-maintainers/2011-November/025757.html
> 
> I think it will work if you use the current stable sources and change
> the new oct-qhull.h file to have
>
>   #define qh_QHpointer 1
>           
> before including the qhull header files.

OK. I will try the above in the current stable branch.
I will report after the build and test. 
 
Thanks!

Tatsuro
> I don't know how to write a test to determine what the definition for
> qh_QHpointer should be so that it matches the installed library, or we
> would have Octave's configure script do this automatically.
> 
> jwe
>